Skip to content

Fix for browser blocking popups #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix for browser blocking popups #158

wants to merge 2 commits into from

Conversation

JacobAClark
Copy link

Removed line creating empty div and added an OR operator in render's block to stop rendering if no container has been created.

@JacobAClark
Bug Fix
4ce3be6 
Moved the initialization of this.container. If the browser blocks popups this.window is null and a TypeError is thrown.

Also added OR operator in render() as if the new window is blocked, no container is created ad React can't create the portal.
@JacobAClark
Update NewWindow.js
550cfbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JacobAClark